handle http error before closing the body#32
Merged
Rucknar merged 1 commit intogithubexporter:masterfrom Jan 31, 2019
Merged
Conversation
This should help with this: panic: runtime error: invalid memory address or nil pointer dereference See example in the http docs: https://golang.org/pkg/net/http/
jlegrone
approved these changes
Jan 16, 2019
jlegrone
left a comment
jlegrone
left a comment
There was a problem hiding this comment.
If anyone else is wondering why not just defer immediately after declaring resp, this is a helpful quote from the docs:
On error, any Response can be ignored. A non-nil Response with a non-nil error only occurs when CheckRedirect fails, and even then the returned Response.Body is already closed.
A response is typically nil on error, so calling Body.Close() panics.
Contributor
Author
|
Could you please merge it and provide a fixed Docker image? |
fstehle
approved these changes
Jan 30, 2019
Contributor
|
Thanks all, i’ll Sort the docker image out today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help with this:
panic: runtime error: invalid memory address or nil pointer dereference
See example in the http docs:
https://golang.org/pkg/net/http/